cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ProjectMoon <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Add support for not (re)starting server a...
Date Fri, 04 Dec 2015 11:07:29 GMT
Github user ProjectMoon commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1162#discussion_r46671185
  
    --- Diff: python/lib/cloudutils/serviceConfigServer.py ---
    @@ -135,9 +135,14 @@ def checkHostName():
                     self.syscfg.svo.disableService("tomcat6")
             except:
                 pass
    -            
    +
             self.syscfg.svo.stopService("cloudstack-management")
    -        if self.syscfg.svo.enableService("cloudstack-management"):
    -            return True
    +
    +        if self.syscfg.env.noStart == False:
    +            if self.syscfg.svo.enableService("cloudstack-management"):
    +                return True
    +            else:
    +                raise CloudRuntimeException("Failed to configure %s, please see the /var/log/cloudstack/management/setupManagement.log
for detail"%self.serviceName)
    --- End diff --
    
    I will change it, but it should be known that this was actually the original message.
:) Does need to be fixed though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message