Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: wilderrodrigues <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
Message-ID: <git-pr-1023-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for
 Egres...
Content-Type: text/plain
Date: Tue,  3 Nov 2015 06:26:18 +0000 (UTC)

GitHub user wilderrodrigues opened a pull request:

    https://github.com/apache/cloudstack/pull/1023

    CLOUDSTACK-8925 - Default allow for Egress rules is not being configured properly in VR iptables rules

    This PR fixes the router default policy for egress. When the default is DENY, the router still allows outgoing connections.
    
    The test component/test_routers_network_ops.py was improved to cover that case as well. The results were:
    
    Test redundant router internals ... === TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
    ok
    Test redundant router internals ... === TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
    ok
    Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
    ok
    Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 4 tests in 3636.656s
    
    OK
    /tmp//MarvinLogs/test_routers_network_ops_QDL429/results.txt (END)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ekholabs/cloudstack fix/egress_state-CLOUDSTACK-8925

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1023.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1023
    
----
commit caa0b4071c024b6672519ab811be733344a05086
Author: Wilder Rodrigues <wrodrigues@schubergphilis.com>
Date:   2015-11-02T11:00:22Z

    CLOUDSTACK-8925 - Drop the traffic when default egress is set to false
    
      - The DROP rule should be appended and the other rules inserted.

commit 9861e997ee81a6aa69e911d0087ad9c60b48f2e3
Author: Wilder Rodrigues <wrodrigues@schubergphilis.com>
Date:   2015-11-02T16:15:46Z

    CLOUDSTACK-8925 - Add tests to cover default egress DENY as well
    
       - Tests cover Redundant and Non-Redundant isolated networks.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---