Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: borisroman <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1083-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1083-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3
 implementatio...
Content-Type: text/plain
Message-Id: <20151120095848.4CC12DFFB9@git1-us-west.apache.org>
Date: Fri, 20 Nov 2015 09:58:48 +0000 (UTC)

Github user borisroman commented on the pull request:

    https://github.com/apache/cloudstack/pull/1083#issuecomment-158344376
  
    @remibergsma Of course I tested manually! Nice Jenkins Job btw ;)
    
    I see three LGTM's, two of which are based on code review, one on running integration tests (which showed nothing broke). I tested the changes in a physical setup, with S3 storage facilities. It does the same as before, so the refactor went well.
    
    Do we merge, or wait for someone else to test? @wido @remibergsma @wilderrodrigues 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---