Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 12AF218927 for ; Mon, 9 Nov 2015 09:09:29 +0000 (UTC) Received: (qmail 25308 invoked by uid 500); 9 Nov 2015 09:09:28 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 25260 invoked by uid 500); 9 Nov 2015 09:09:28 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 25249 invoked by uid 99); 9 Nov 2015 09:09:28 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Nov 2015 09:09:28 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4B063DFE80; Mon, 9 Nov 2015 09:09:28 +0000 (UTC) From: wido To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ... Content-Type: text/plain Message-Id: <20151109090928.4B063DFE80@git1-us-west.apache.org> Date: Mon, 9 Nov 2015 09:09:28 +0000 (UTC) Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155001934 @DaanHoogland @borisroman Fully agree, the UI is currently not the best, but this change can go in. I want to LGTM, but it's hard to test. The code seems fine to me. I'll give my LGTM after @borisroman shows me it works. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---