Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7729818D44 for ; Sun, 8 Nov 2015 14:41:50 +0000 (UTC) Received: (qmail 44145 invoked by uid 500); 8 Nov 2015 14:41:50 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 44081 invoked by uid 500); 8 Nov 2015 14:41:50 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 44070 invoked by uid 99); 8 Nov 2015 14:41:49 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Nov 2015 14:41:49 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 76994E02FF; Sun, 8 Nov 2015 14:41:49 +0000 (UTC) From: bhaisaab To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: Metrics views for CloudStack UI Content-Type: text/plain Message-Id: <20151108144149.76994E02FF@git1-us-west.apache.org> Date: Sun, 8 Nov 2015 14:41:49 +0000 (UTC) Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1038#issuecomment-154830156 @DaanHoogland thanks for taking time to review this, on my system I'm still able to get the metrics button on Chrome/Firefox/Safari. Can you simply take the shapeblue:metrics-master repo/branch which is where the PR is created form, there is no hidden or missing commit. In the html source (of index.jsp being rendered) can you find metrics.js and metricsView.js included somewhere? Can you confirm if you're building and running mgmt server with mvn or testing using an rpm? It might be an environment issue, or browser caching issue or that your test branch is missing commits from the PR (something went wrong with applying the PR?) See, I'm able to see the metrics button/views and note that UI is wider than before: ![screen shot 2015-11-08 at 8 03 52 pm](https://cloud.githubusercontent.com/assets/95203/11020859/f2fbc1a2-8653-11e5-8b06-47b4117cd847.png) ![screen shot 2015-11-08 at 8 05 27 pm](https://cloud.githubusercontent.com/assets/95203/11020866/16b79242-8654-11e5-8641-2d9129ee2f42.png) ![screen shot 2015-11-08 at 8 06 46 pm](https://cloud.githubusercontent.com/assets/95203/11020874/5730b8c6-8654-11e5-8b5d-619a3a89ac3f.png) Another place you can check is to go see if you see a viewMetrics codeblock in instances.js (or system.js, or storage.js) in scripts/, like this: (this code is like an API for rendering the metrics button, navigation, setting up view etc) ![screen shot 2015-11-08 at 8 08 07 pm](https://cloud.githubusercontent.com/assets/95203/11020881/8e71dd56-8654-11e5-84c2-365786b186cd.png) Also, is anyone else able to reproduce the issue Daan is facing? cc @wido @wilderrodrigues @abhinandanprateek @NuxRo and others? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---