Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
HMM_SOURCE_IP: 10.64.8.33:58122.45248842
HMM_ATTACHE_NUM: 0000
HMM_SOURCE_TYPE: SMTP
Received: from qianshthink (unknown [10.64.8.33])
	by 189.cn (HERMES) with ESMTP id ECC7317C193
	for <dev@cloudstack.apache.org>; Wed, 18 Nov 2015 15:23:00 +0800 (CST)
Received: from qianshthink ([36.110.61.109])
	by zm-as3(MEDUSA 0.0.0.0) with ESMTP id aa3677d0-9a9b-4617-bac2-80abb628e76c
 for dev@cloudstack.apache.org;
	Wed Nov 18 15:23:11 2015
0/X-Total-Score: 0:
X-FILTER-SCORE: to=<85869761848d909685949582848c4f8291828489864f909388>,
 score=<1447831391kmTM19DKyyyyyjyykyymyjmyEVWqf2dddddKddmddydK>  
X-REAL-FROM: windyii@189.cn
X-Receive-IP: 36.110.61.109
From: "Qian Shaohua" <windyii@189.cn>
To: <dev@cloudstack.apache.org>
Subject: [KVM] NPE when createVolume by a snapshot whose source volume is
 deleted
Date: Wed, 18 Nov 2015 15:23:01 +0800
Message-ID: <001901d121d1$f602dfc0$e2089f40$@cn>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_NextPart_000_001A_01D12215.04261FC0"
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: AdEh0fUCI7xoDCMZTZm7865Qm+u/kA==
Content-Language: zh-cn

------=_NextPart_000_001A_01D12215.04261FC0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit

Hi all,

 
CS 4.5.2 KVM

KVMStorageProcessor checks source volume of a snapshot for the ImageFormat
in createVolumeFromSnapshot(CopyCommand cmd).

If the source volume is deleted, we get NPE.

 
2015-11-18 14:02:57,259 DEBUG [o.a.c.e.o.VolumeOrchestrator]
(API-Job-Executor-35:ctx-0c1e2671 job-2795 ctx-5108a77c) Failed to create
volume from snapshot:java.lang.NullPointerException

        at
com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.createVolumeFromSnapsho
t(KVMStorageProcessor.java:1237)

        at
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(Storag
eSubsystemCommandHandlerBase.java:97)

        at
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageC
ommands(StorageSubsystemCommandHandlerBase.java:53)

        at
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(Li
bvirtComputingResource.java:1406)

        at com.cloud.agent.Agent.processRequest(Agent.java:503)

        at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:808)

        at com.cloud.utils.nio.Task.run(Task.java:84)

        at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:11
45)

        at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:6
15)

        at java.lang.Thread.run(Thread.java:744)

 
It isn't fix in master as we know.

Shall we save format info in snapshots table and get rid of the dependency?

Or give the volume info in CopyCommand even if the volume is deleted?

 
--

Qian


------=_NextPart_000_001A_01D12215.04261FC0--