cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <>
Subject [GitHub] cloudstack pull request: [4.5] CLOUDSTACK-4787 - vmware diskcontro...
Date Fri, 27 Nov 2015 13:20:58 GMT
GitHub user bhaisaab opened a pull request:

    [4.5] CLOUDSTACK-4787 - vmware diskcontrollers
    Allows users to configure (root and data) disk controllers for vm and vm templates.
    Select disk controller while registering VM in UI:
    ![screenshot from 2015-11-27 15-32-37](
    Verified custom disk controller on vCenter/vSphere client:
    ![screenshot from 2015-11-27 18-27-57](

You can merge this pull request into a Git repository by running:

    $ git pull 4.5-vmware-diskcontrollers

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1131
commit 4a48427ea49cdd3154ce7b3b574cad502b6b0062
Author: Sateesh Chodapuneedi <>
Date:   2015-01-14T02:43:10Z

    CLOUDSTACK-4787 Allow selection of scsi controller type in vSphere
        commit #7
        So far only 1 controller (scsi or ide) is supported in Cloudstack for ide or
        scsi, this is existing limitation. Added support for 2nd IDE controller. Support adding
        virtual disk to VM. Also added check if VM is running as IDE virtual disk cannot be
        to VM if VM is runnning.If user detaches a virtual disk on lower unit number of controller,
        then subsequent attach operation should find free unit number on the controller and
        the virtual disk there.
        commit #6
        Let the controllers of existing VMs continue without flip, current busInfo retrieved
        chain_info field of volume record from database would be preferred over
        controller settings from all configuration settings.
        commit #5
        Editing global configuration param vmware.root.disk.controller osdefault value results
        in loss of previous root disk controller type. Hence root disk's controller type for
        VMs is unknow post that modificaiton by user. If VM is stop/start then we could get
        infromation from bus info of existing volume. But if user resets VM and then try to
start VM.
        The existing bus info would be lost. Hence existing disk info is not available to
depend on.
        Using lsilogic or generic scsi controller for ROOT disk of legacy VMs if reset.
        commit #4
        Avoid adding additional (>1) scsi controllers to system vms. While attaching volume
to legacy VM
        don't use osdefault optoin which applicable only for VM created with the option enabled,
        legacy data disk controller type (lsilogic)
        commit #3
        If root disk's controller type is scsi and data disk controller type condenses
        to any of scsi sub-types then data disk controller type would fall back to root disk
controller itself. This
        ensures data volumes would be accessible in all cases as controller of root volume
would be reliable
        and it means VM has the supported controller. It also avoids mix of scsi controller
sub-types in a user instance.
        Also translating disk controller type scsi to lsilogic.
        commit #2
        Support auto detection of recommended virtual disk controller type for specific guest
        commit #1
        Support granual controller types. Add support for controller types in template registration
as well.
        Fix white spaces.
        Removed stale HEAD merge lines
        Removed tail of merge lines
        Fixed VmwareResource, removing storage commands that moved to VmwareStorageProcessor.
        removed stale code of controller that is present in processor
        Fixed check style errors.
        Fixed injection.
        Tested with Linux and windows templates. Unable to run iso based tests due to few
bugs in register iso area.
        Signed-off-by: Sateesh Chodapuneedi <>
    (cherry picked from commit a4cc987a6f66f20c434942956fffe5951df09e43)
    Signed-off-by: Rohit Yadav <>

commit c7d67628b3ff86802a1ac3b58e0bc05d54afd543
Author: Rohit Yadav <>
Date:   2015-11-27T13:00:00Z

    CLOUDSTACK-4787: Allow users to select disk controller for VM/template
    - Adds new controller types in the UI, for selecting root disk controller while
      registering templates
    - Fixes bug to not override disk controller type if provided in the details (either
      vm details or from template details)
    Signed-off-by: Rohit Yadav <>


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message