cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ProjectMoon <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix event UUIDS missing on event bus
Date Thu, 26 Nov 2015 11:23:49 GMT
GitHub user ProjectMoon opened a pull request:

    https://github.com/apache/cloudstack/pull/1127

    Fix event UUIDS missing on event bus

    Same as pull request #1111, but this time on the 4.6 branch for forward merging in accordance
with [the wiki](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up#ReleaseprinciplesforApacheCloudStack4.6andup-HowtomergeaPullRequest?).
    
    The fixing of CLOUDSTACK-8816 introduced a regression that removed the first class entities
in the event bus description property. This is because everything was changed to use the Class
as a key... Everything but the populateFirstClassEntities method in ActionEventUtils.
    
    This commit tries to load the class key instead of the String key, which re-enables the
populateFirstClassEntities method.
    
    Likely this was not caught because of the trace exception handling... maybe some better
logging/unit tests would be good for this PR.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greenqloud/cloudstack pr-eventbus-uuids-4.6

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1127
    
----
commit 7d44e90c8df13146918c66cebdbb2573e1dec4ce
Author: jeff <jeff@greenqloud.com>
Date:   2015-11-23T17:15:57Z

    Fix event UUIDS missing on event bus
    
    The fixing of CLOUDSTACK-8816 introduced a regression that removed the
    first class entities in the event bus description property. This is
    because everything was changed to use the Class as a key... Everything
    but the populateFirstClassEntities method in ActionEventUtils.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message