cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9083: Add disk serial to kvm v...
Date Wed, 25 Nov 2015 09:44:48 GMT
GitHub user bhaisaab opened a pull request:

    https://github.com/apache/cloudstack/pull/1121

    CLOUDSTACK-9083: Add disk serial to kvm virt xml

    Adds disk serial ids based on volume uuids to the virt xml. This may be useful
    for appliances/software that needs some serial ids on the VM disks. This does not
    impact existing/running VMs, the vm virt xmls will be updates for running VMs
    the next time they are stopped/started.
    
    For testing, disk serial (of debian based systemvm) in the virt xml matched that
    in /sys/devices/pci0000:00:0000:00:07.0/virtio4/block/vda/serial.
    
    We currently don't support scsi-blcok devices for which serial is not supported,
    for this we've added a DeviceType (LUN) which may be used in future and a check
    to not add the serial to the xml if disk type is LUN.
    Refer: https://libvirt.org/formatdomain.html#elementsDisks

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack 4.6-cloudstack-9083

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1121
    
----
commit 12c395b56052af36901ab3ed1a366ed8985740eb
Author: Rohit Yadav <rohit.yadav@shapeblue.com>
Date:   2015-11-25T09:07:40Z

    CLOUDSTACK-9083: Add disk serial to kvm virt xml
    
    Adds disk serial ids based on volume uuids to the virt xml. This may be useful
    for appliances/software that needs some serial ids on the VM disks. This does not
    impact existing/running VMs, the vm virt xmls will be updates for running VMs
    the next time they are stopped/started.
    
    For testing, disk serial (of debian based systemvm) in the virt xml matched that
    in /sys/devices/pci0000:00:0000:00:07.0/virtio4/block/vda/serial.
    
    We currently don't support scsi-blcok devices for which serial is not supported,
    for this we've added a DeviceType (LUN) which may be used in future and a check
    to not add the serial to the xml if disk type is LUN.
    Refer: https://libvirt.org/formatdomain.html#elementsDisks
    
    Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message