cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Removed unnecessary @Local annotations an...
Date Sat, 21 Nov 2015 20:44:39 GMT
GitHub user cristofolini opened a pull request:

    https://github.com/apache/cloudstack/pull/1102

    Removed unnecessary @Local annotations and their respective imports

    Following @rafaelweingartner 's findings in PR #714 that many spring beans contained an
@Local annotation, we've decided to remove said annotations and their imports from the ComponentLifecycleBase
class and its subclasses seeking a reduction of a few hundred lines of useless code.
    
    I had already opened a pull request for this (#853) but at some point my commit disappeared
from the PR entirely, showing no new changes in code, which caused it to be merged automatically
(with no changes).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rafaelweingartner/cloudstack master-lrg-cs-hackday-006

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1102
    
----
commit 1a64c247adbeb326f7ddbe6e4feaf3159e9e740d
Author: cirstofolini <lucascristofolini@gmail.com>
Date:   2015-11-21T20:31:11Z

    Removed unnecessary @Local annotations and their respective imports from the ComponentLifecycleBase
class and its subclasses.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message