cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdube <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Show Agent name in Ping response
Date Mon, 30 Nov 2015 16:12:04 GMT
Github user pdube commented on the pull request:

    https://github.com/apache/cloudstack/pull/1143#issuecomment-160674157
  
    LGTM, but consider using the default log4j formatter. ex:
    `logger.debug("Ping from {} ({})", hostid, hostname);`
    and extracting the message to a constant


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message