cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Date Mon, 30 Nov 2015 15:47:45 GMT
Github user nvazquez commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1094#discussion_r46159749
  
    --- Diff: api/src/com/cloud/network/Networks.java ---
    @@ -251,6 +252,10 @@ public static URI fromString(String candidate) {
                     if (com.cloud.dc.Vlan.UNTAGGED.equalsIgnoreCase(candidate)) {
                         return Native.toUri(candidate);
                     }
    +                if (UuidUtils.validateUUID(candidate)){
    +                    //Supporting lswitch uuid as vlan id: set broadcast_uri = null and
add row on nicira_nvp_router_map with logicalrouter_uuid = candidate
    +                    return null;
    --- End diff --
    
    The idea is to support creating Shared Networks over NSX Managed Network Offering, so
there will be this two cases (for creation):
    * Providing numerical VLAN_ID:
     * broadcastdomain_type = Lswitch
     * broadcast_uri = "vlan://VLAN_ID"
    * Providing logical router UUID as VLAN_ID:
     * broadcastdomain_type = Lswitch
     * broadcast_uri = NULL
     * add entry on nicira_nvp_router_map with network id and logical router's UUID
    
    For second case, I included the code in the catch block as I asumed that VLAN_ID provided
is not numerical (as long parsing fail). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message