cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Date Mon, 30 Nov 2015 14:26:01 GMT
Github user nvazquez commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1094#discussion_r46148014
  
    --- Diff: api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
    @@ -0,0 +1,12 @@
    +package com.cloud.network.guru;
    +
    +import java.util.Map;
    +
    +public interface NetworkGuruAdditionalFunctions {
    --- End diff --
    
    I agree. This was the "best" solution I found, maybe for my lack CS architecture knowledge.
This was the problem that I faced:
    I needed to call this functions from NetworkOrchestrator. However, from NetworkOrchestrator
I could access NetworkGuru interface, so I decided not to include this methods in NetworkGuru
interface, implementing them blank in every guru except in NiciraNvpGuestNetworkGuru. I decided
to create this interface, only implemented by NiciraNvpGuestNetworkGuru just to avoid doing
that.
    
    In NetworkOrchestrator, line 682 I made a call to one of this functions. How can I improve
this solution?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message