cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Date Mon, 30 Nov 2015 07:26:12 GMT
Github user miguelaferreira commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1094#discussion_r46114312
  
    --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/element/NiciraNvpElement.java
---
    @@ -239,8 +244,51 @@ public boolean implement(Network network, NetworkOffering offering,
DeployDestin
              * multiple operations that should be done only once.
              */
     
    -        // Implement SourceNat immediately as we have al the info already
    -        if (networkModel.isProviderSupportServiceInNetwork(network.getId(), Service.SourceNat,
Provider.NiciraNvp)) {
    +        if (network.getGuestType().equals(GuestType.Shared)){
    --- End diff --
    
    This block (and the next) add to an already large method. It would be best to refactor
it to new methods (or a new object altogether).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message