cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Date Mon, 30 Nov 2015 07:23:26 GMT
Github user miguelaferreira commented on a diff in the pull request:
    --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/
    @@ -671,8 +672,19 @@ public void doInTransactionWithoutResult(TransactionStatus status)
                                     vpcId, offering.getRedundantRouter());
                             vo.setDisplayNetwork(isDisplayNetworkEnabled == null ? true :
    -                        networks.add(_networksDao.persist(vo, vo.getGuestType() == Network.GuestType.Isolated,
    -                                finalizeServicesAndProvidersForNetwork(offering, plan.getPhysicalNetworkId())));
    +                        NetworkVO networkPersisted = _networksDao.persist(vo, vo.getGuestType()
== Network.GuestType.Isolated,
    --- End diff --
    This block adds more code to an already oversized method. This would best be extracted
as a new method or even a new object. This way it would be easier to read and unit-test.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message