cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Date Mon, 30 Nov 2015 07:20:59 GMT
Github user miguelaferreira commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1094#discussion_r46114122
  
    --- Diff: api/src/org/apache/cloudstack/api/response/NicResponse.java ---
    @@ -102,6 +102,14 @@
         @Param(description = "Id of the vm to which the nic belongs")
         private String vmId;
     
    +    @SerializedName("nsxlogicalswitch")
    +    @Param(description = "Id of the NSX Logical Switch (if NSX based), null otherwise",
since="4.6.0")
    +    private String nsxlogicalswitch;
    +
    +    @SerializedName("nsxlogicalswitchport")
    +    @Param(description = "Id of the NSX Logical Switch Port (if NSX based), null otherwise",
since="4.6.0")
    +    private String nsxlogicalswitchport;
    --- End diff --
    
    variable naming convention not being followed here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message