cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Date Mon, 30 Nov 2015 07:13:03 GMT
Github user miguelaferreira commented on a diff in the pull request:
    --- Diff: api/src/com/cloud/network/ ---
    @@ -251,6 +252,10 @@ public static URI fromString(String candidate) {
                     if ( {
                         return Native.toUri(candidate);
    +                if (UuidUtils.validateUUID(candidate)){
    +                    //Supporting lswitch uuid as vlan id: set broadcast_uri = null and
add row on nicira_nvp_router_map with logicalrouter_uuid = candidate
    +                    return null;
    --- End diff --
    I've read the comment in the line above a few times, and still cannot understand the purpose
of returning null on an invalid UUID (i.e. you previously caught a number format exception).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message