cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...
Date Sun, 29 Nov 2015 08:50:24 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1121#discussion_r46089183
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
    @@ -419,7 +419,7 @@ public String toString() {
     
         public static class DiskDef {
             public enum DeviceType {
    -            FLOPPY("floppy"), DISK("disk"), CDROM("cdrom");
    +            FLOPPY("floppy"), DISK("disk"), CDROM("cdrom"), LUN("lun");
    --- End diff --
    
    SCSI block devices, LUN are not supported; the type was added to avoid possible bug in
case we decide to support this storage/device type in future. See https://libvirt.org/formatdomain.html#elementsDisks
for details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message