cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: 4.6 to master
Date Sat, 28 Nov 2015 20:02:57 GMT
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1136#issuecomment-160332479
  
    LGTM, since the change is in the UI I built that from this branch.
    
    Two checks:
    - The metrics feature still works properly
    ![screen shot 2015-11-28 at 20 58 26 pm](https://cloud.githubusercontent.com/assets/1630096/11453635/e7443bd6-9612-11e5-9474-908edc84451b.png)
    
    - The bug mentioned in #1119 is resolved, as the fix was merged to 4.6 and now lands in
master.
    The instance tab now shows "No data to show" instead of an endless loading loop.
    ![screen shot 2015-11-28 at 20 55 05 pm](https://cloud.githubusercontent.com/assets/1630096/11453647/145b5172-9613-11e5-87c7-0fe370779654.png)
    
    Thanks @DaanHoogland for resolving the merge conflict.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message