cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.6] Add select template dropdown when r...
Date Sat, 28 Nov 2015 13:37:22 GMT
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1101#issuecomment-160296390
  
    @ustcweizhou LGTM, tested it and works as expected.
    
    Minor comment: the first item in the list is empty (it will then keep the same template),
rest of the items are the available templates. Should we make that first entry more explicit
("keep same template" or so)?
    
    ![screen shot 2015-11-28 at 14 28 31 pm](https://cloud.githubusercontent.com/assets/1630096/11452139/637621be-95dd-11e5-8048-a623968edb24.png)
    
    Tried both and they work fine:
    ![screen shot 2015-11-28 at 14 36 32 pm](https://cloud.githubusercontent.com/assets/1630096/11452143/7af87cce-95dd-11e5-8391-d572d7f1797c.png)
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message