cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...
Date Fri, 27 Nov 2015 18:49:06 GMT
Github user remibergsma commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1007#discussion_r46066286
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final DedicatePublicIpRangeCmd
cmd) throws Res
                 vlanOwner = _accountMgr.getAccount(project.getProjectAccountId());
             }
     
    +        Domain domain = null;
             if (accountName != null && domainId != null) {
                 vlanOwner = _accountDao.findActiveAccount(accountName, domainId);
    -        }
    -        if (vlanOwner == null) {
    -            throw new InvalidParameterValueException("Unable to find account by name
" + accountName);
    -        } else if (vlanOwner.getId() == Account.ACCOUNT_ID_SYSTEM) {
    -            throw new InvalidParameterValueException("Please specify a valid account.
Cannot dedicate IP range to system account");
    +            if (vlanOwner == null) {
    --- End diff --
    
    @koushik-das You OK with the PR like it is now? Please review again, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message