cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Removed the PlannerBase class because it ...
Date Mon, 23 Nov 2015 14:35:44 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1108#issuecomment-158952872
  
    less is more. Are there no other types of Planner{}s then DeploymentPlanner{}s? and in
addition Interfaces are a betterway to signify types if/when there is no shared code.
    
    LGTM based on the code and explenation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message