cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...
Date Fri, 20 Nov 2015 09:43:39 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1066#discussion_r45450911
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceData.java
---
    @@ -0,0 +1,289 @@
    +package com.cloud.hypervisor.xenserver.resource;
    +
    +import java.util.LinkedList;
    +import java.util.Queue;
    +
    +public class CitrixResourceData {
    --- End diff --
    
    What is the need/justification for creating this data class? The data members were already
part of appropriate XS resource classes. I don't see any benefit here from another level of
indirection.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message