cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Date Fri, 20 Nov 2015 09:26:07 GMT
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1094#issuecomment-158334828
  
    LGTM, based on a set of tests that I run on this branch (which I rebased myself first).
Screenshot is from an experimental Jenkins job (that runs the same tests I did manually until
now).
    
    These test may not cover your change, all they do is show you didn't break them. Someone
else needs to review the code.
    
    ![1094_test_results](https://cloud.githubusercontent.com/assets/1630096/11296170/d08de85e-8f70-11e5-8d0f-3ae7a735afa1.png)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message