cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...
Date Thu, 19 Nov 2015 12:52:26 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1083#issuecomment-158048085
  
    @borisroman @wido I made some comments in the PR. Those are not blocking, but would be
very fruitful to get them in place in a second round of the refactor.
    
    The public constructor and hashCode()/equals() methods can be address before the merge.
But the refactor can take place within a couple of weeks.
    
    @borisroman: feel free to drop by on 1st December, or any other date on that week, so
we can do it together.
    
    It LGTM :+1: based on my code review.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message