cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...
Date Thu, 19 Nov 2015 12:37:21 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1083#discussion_r45335103
  
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/storage/AddImageStoreS3CMD.java
---
    @@ -119,17 +129,16 @@ public void execute() throws ResourceUnavailableException, InsufficientCapacityE
                 dm.put(ApiConstants.S3_USE_TCP_KEEPALIVE, getUseTCPKeepAlive().toString());
             }
     
    -
             try{
                 ImageStore result = _storageService.discoverImageStore(null, null, "S3",
null, dm);
    -            ImageStoreResponse storeResponse = null;
    +            ImageStoreResponse storeResponse;
    --- End diff --
    
    Clever... loved it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message