cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...
Date Thu, 19 Nov 2015 12:35:17 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1083#discussion_r45334945
  
    --- Diff: api/src/com/cloud/agent/api/to/S3TO.java ---
    @@ -51,8 +52,8 @@ public S3TO() {
         }
     
         public S3TO(final Long id, final String uuid, final String accessKey, final String
secretKey, final String endPoint, final String bucketName,
    -            final Boolean httpsFlag, final Integer connectionTimeout, final Integer maxErrorRetry,
final Integer socketTimeout, final Date created,
    -            final boolean enableRRS, final long maxUploadSize, final Integer connectionTtl,
final Boolean useTCPKeepAlive) {
    +            final String signer, final Boolean httpsFlag, final Integer connectionTimeout,
final Integer maxErrorRetry, final Integer socketTimeout,
    +            final Date created, final boolean enableRRS, final long maxUploadSize, final
Integer connectionTtl, final Boolean useTCPKeepAlive) {
     
             super();
    --- End diff --
    
    You can remove this call and also remove the public default constructor: it's not used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message