cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9067 - As I developer I want t...
Date Wed, 18 Nov 2015 12:17:59 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1084#issuecomment-157693480
  
    @miguelaferreira discussed with me the over-engineering wrapper method just to add 1 test
and we agreed on getting rid of it for the following reasons:
    
    1. It could lead other committers to add simple tests - like the one I added - and forget
about the real tests that we need;
    2. An experienced Software Engineer reviewing the code will spot problems with the string
formats used.
    
    I will retest the PR and post the results here.
    
    Cheers,
    Wilder 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message