cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...
Date Wed, 18 Nov 2015 06:36:32 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1079#issuecomment-157619773
  
    Okay, understood.
    
    I just read the other PR and saw your details about the tests, how you did it, ando also
saw that @remibergsma already tested the existing features: which are working fine.
    
    So, given the tests description + the LGTM from @remibergsma based on the marvin tests
results, I LGTM this PR.
    
    @dsclose: do you have any experience writing marvin tests? We can help you out. We need
a test to cover what you described.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message