cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...
Date Tue, 17 Nov 2015 14:54:13 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1066#issuecomment-157392000
  
    Hi @DaanHoogland,
    
    I run integration tests before creating the PRs and that's not manually and I do have
only 1 bubble. I just do:
    
    * build code/RPMs
    * run MS
    * deploy DC
    * run tests
    
    I could do that before the bubble as well... remember my endless iptables list? ;)
    
    I only feel comfortable with creating a PR if I know the system is still working. I have
been fixing problems before due to PRs that were not tested and broke master. With me it only
happened 2 times, but it took me 4 weeks to find out which commit - not mine - broke it. I
am just trying to avoid that again.
    
    Concerning the inline get calls, you don't have to change it. It would improve readability,
but that's not a blocker. However, the PR needs to be tested against XenServer at least by
1 reviewer - or a CI that tests something (not against a simulator). 
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message