cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...
Date Tue, 17 Nov 2015 09:38:47 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/935#discussion_r45038549
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
    @@ -2076,6 +2087,9 @@ private static void postNvpConfigBeforeStart(VirtualMachineMO vmMo,
VirtualMachi
                     } else if (backing instanceof VirtualEthernetCardNetworkBackingInfo)
{
                         // This NIC is connected to a Virtual Switch
                         // Nothing to do
    +                } else if (backing instanceof VirtualEthernetCardOpaqueNetworkBackingInfo)
{
    +                    //if NSX API VERSION >= 4.2, connect to br-int (nsx.network),
do not create portgroup else previous behaviour
    +                    //OK, connected to OpaqueNetwork
    --- End diff --
    
    Those 2 else/if blocks should contain some logging in order to inform sys admins what
is now comments in the code.
    
    You can keep it for now, because it doesn't affect the feature that @miguelaferreira has
already tested. Once this PR is merged, we can fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message