cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [WIP] CLOUDSTACK-9063 CitrixResourceBase ...
Date Mon, 16 Nov 2015 10:05:39 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1066#issuecomment-156976829
  
    I will look at the changes to see if extra unit tests are needed. I have not introduced
any logical changes so far.
    I aggree that we should not merge anything called [WIP]... it shall have to be renamed
before merging. It does not contradict the way we have worked lately.
    Making it a PR gives the advantage of the automated tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message