cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [WIP] CLOUDSTACK-9063 CitrixResourceBase ...
Date Mon, 16 Nov 2015 08:33:28 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1066#issuecomment-156955059
  
    Hi @DaanHoogland 
    
    Since this is still WIP, would be nice to extract local variable instead of calling all
those methods in line. Also, I haven't seen any change in the existing unit tests.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message