cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...
Date Wed, 11 Nov 2015 17:31:08 GMT
GitHub user DaanHoogland reopened a pull request:

    https://github.com/apache/cloudstack/pull/1056

    CID-1338387: handle unknown storage endpoint

    I have removed the paramoia null check and created a specific exception as i think we
always should for any specific condition. This would require careful consideration each time
on whether and how specific the condition is of course ;)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaanHoogland/cloudstack CID-1338387

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1056.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1056
    
----
commit 7b76cd2fb40d7b26bd786a4a0f8724d8c316a9d3
Author: Daan Hoogland <daan@onecht.net>
Date:   2015-11-10T11:53:35Z

    CID-1338387: paranoia null checking

commit a67fc10461b5d0b7482c4cd18267cc3a6bc020d2
Author: Daan Hoogland <daan@onecht.net>
Date:   2015-11-10T16:52:50Z

    CID-1338387 specific exception for specific condition

commit 78d35465d7b24b6c9f569dbe83529c3fed2e2071
Author: Daan Hoogland <daan@onecht.net>
Date:   2015-11-10T17:02:55Z

    forgotten details
    
    throw on host is null
    no iteration for retrieving only one element

commit b0bbba21d3bd1e1332dc72a1caeb4a4cd85d7f4b
Author: Daan Hoogland <daan@onecht.net>
Date:   2015-11-11T17:28:02Z

    CID-1338387 removal of unnecessary code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message