cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...
Date Wed, 11 Nov 2015 11:31:49 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1059#issuecomment-155741147
  
    LGTM by code inspection. The issue is obvious and the solution as well. I do agree with
@wilderrodrigues that permanent validation of the issue is needed. In this case a ref to a
unit test may be enough if it exists. otherwise a marvin/integration test would be fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message