cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...
Date Wed, 11 Nov 2015 07:42:42 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1056#issuecomment-155694568
  
    @miguelaferreira  Optional is very clear indeed. So is exception handling. When you need
to handle a possible null return one level deep optional is fine. Newbees look at the code
of one hypervisor guru as example of the code for an other hypervisor guru. Let's not implement
a different solution strategy in each but find a solution that works in a generic way, avoiding
confusion on the part of the spectator.
    
    @rafaelweingartner your stubbornness is much appreciated. I want to understand exactly
what happens as well. You have not convinced me that the call is without side effects yet.
At the very least an EndPoint object is created by the spring framework. I don't say that
this side effect is desired but I want to be sure before just cutting the code away. The endpoint
in a storage subsystem is not intended to be the same as a hypervisor and maybe I let let
myself be misled by that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message