cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...
Date Tue, 10 Nov 2015 23:00:22 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1056#issuecomment-155595167
  
    @DaanHoogland, sorry if I am being stubborn, but I really do not see what the method “endPointSelector.selectHypervisorHost”
is used for; at the end we get the “EndPoint” and use just the host_id of that object,
then we load the host using that id and the details of that host. 
    
    My point is that, if the host does not matter, why not use the host we have already loaded
in line 113, and then load the details of that host. If we do that, we can remove the “endPointSelector.selectHypervisorHost”
method. 
    
    The configure method you talked about (org.apache.cloudstack.storage.RemoteHostEndPoint.configure(Host))
will load the “publicAddress”,if the host it receives as a parameter is a SSVM. However,
the select “select h.id from host h where h.status = 'Up' and h.hypervisor_type is not null”
that is executed in (endPointSelector.selectHypervisorHost) will not return any of the system
VMs, because they have “hypervisor_type” value as null. Therefore, we are using that method
without needing it; that method will just return a random host of the environment.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message