cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...
Date Tue, 10 Nov 2015 12:07:40 GMT
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/1055#issuecomment-155403829
  
    did a mvn build on the pr and manually verified the api call. the private key isn't logged
anymore.
    
    before
    ```
    2015-11-10 17:13:18,462 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-3:ctx-74dad1b6
job-799) Executing AsyncJobVO {id:799, userId: 2, accountId: 2, instanceType: None, instanceId:
null, cmd: org.apache.cloudstack.api.command.admin.resource.UploadCustomCertificateCmd, cmdInfo:
{"sessionkey":"UZeTJmhKlSkEyt9O1H0QceBb3yI","cmdEventType":"UPLOAD.CUSTOM.CERTIFICATE","ctxUserId":"2","signatureversion":"3","httpmethod":"GET","response":"json","domainsuffix":"abc.com","ctxDetails":"{}","certificate":"123","expires":"2015-11-10T12:04:08+0000","ctxAccountId":"2","ctxStartEventId":"2089","privatekey":"private123"},
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid:
233845178473200, completeMsid: null, lastUpdated: null, lastPolled: null, created: null}
    ```
    
    after
    ```
    2015-11-10 17:22:59,986 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-1:ctx-3c64d80b
job-800) Executing AsyncJobVO {id:800, userId: 2, accountId: 2, instanceType: None, instanceId:
null, cmd: org.apache.cloudstack.api.command.admin.resource.UploadCustomCertificateCmd, cmdInfo:
{"sessionkey":"9kO_Di2wrf2ekMKCYrveEjCtTg8","cmdEventType":"UPLOAD.CUSTOM.CERTIFICATE","ctxUserId":"2","signatureversion":"3","httpmethod":"GET","response":"json","domainsuffix":"abc.com","ctxDetails":"{}","certificate":"123","expires":"2015-11-10T12:13:49+0000","ctxAccountId":"2","ctxStartEventId":"2091",},
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid:
233845178473200, completeMsid: null, lastUpdated: null, lastPolled: null, created: null}
    ```
    
    LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message