cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...
Date Sat, 07 Nov 2015 10:29:09 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1021#discussion_r44210897
  
    --- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java ---
    @@ -71,4 +83,19 @@ public boolean shouldSkipField(FieldAttributes f) {
                 return false;
             }
         }
    +
    +    private static class LogExclusionStrategy extends ApiResponseExclusionStrategy implements
ExclusionStrategy {
    +        public boolean shouldSkipClass(Class<?> arg0) {
    +            return false;
    +        }
    +
    +        public boolean shouldSkipField(FieldAttributes f) {
    +            boolean skip = super.shouldSkipField(f);
    +            if (!skip) {
    +                LogLevel logLevel = f.getAnnotation(LogLevel.class);
    --- End diff --
    
    suggest:
    ```
                    Param sensitivity = f.getAnnotation(Param.class);
                    skip = (sensitivity != null && sensitivity.isSensitive());
    ```
    extra changes are needed fro this on the response classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message