cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...
Date Fri, 06 Nov 2015 13:01:07 GMT
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1027#issuecomment-154403884
  
    @ustcweizhou I looked at the code more closely and it looks good.
    
    However, I would still vote for having the Agent port always enabled. This saves a lot
of code and a lot of testing as well.
    
    I would also remove the Python code and write a Java Util which directly talks to the
local Unix socket.
    
    So, we always enable a Guest Agent port and when we want to talk to the Instance we send
a ping. If it responds, it responds. If not, we assume there is no Agent in there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message