cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [blocker/critical] CLOUDSTACK-9025 : [Xen...
Date Wed, 04 Nov 2015 10:05:38 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1030#issuecomment-153668049
  
    I am not sure why this PR is marked blocker/critical. The implemented code is a nested.
It should have been a factored out check-method with unit test, not withstanding the integration
test instructions in it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message