cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9013: Virtual router failed to...
Date Mon, 02 Nov 2015 10:44:40 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1014#issuecomment-152984837
  
    Hi @DaanHoogland @remibergsma @ustcweizhou, the change LGTM! :+1: 
    
    The tests I have use an isolated network with default egress as "allow", so that part
of the code was not being covered.
    
    It was a copy/paste error.
    
    Please, @remibergsma , proceed with the merge.
    
    Thanks for the fix, @ustcweizhou!
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message