Return-Path: 
 <dev-return-82988-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DBEE31811E
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Tue, 27 Oct 2015 08:20:10 +0000 (UTC)
Received: (qmail 36357 invoked by uid 500); 27 Oct 2015 08:20:02 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 36304 invoked by uid 500); 27 Oct 2015 08:20:02 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 36293 invoked by uid 99); 27 Oct 2015 08:20:01 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2015 08:20:01 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id C186BDFC89; Tue, 27 Oct 2015 08:20:01 +0000 (UTC)
From: nlivens <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-801-cloudstack@git.apache.org>
In-Reply-To: <git-pr-801-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP
 plugin...
Content-Type: text/plain
Message-Id: <20151027082001.C186BDFC89@git1-us-west.apache.org>
Date: Tue, 27 Oct 2015 08:20:01 +0000 (UTC)

Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43093076
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java ---
    @@ -40,9 +43,61 @@ public String getVpcUuid() {
             return _vpcUuid;
         }
     
    +    public String getDomainTemplateName() {
    +        return _domainTemplateName;
    +    }
    +
    +    public static class Builder implements CmdBuilder<ShutDownVpcVspCommand> {
    +        private String _domainUuid;
    +        private String _vpcUuid;
    +        private String _domainTemplateName;
    +
    +        public Builder domainUuid(String domainUuid) {
    +            this._domainUuid = domainUuid;
    +            return this;
    +        }
    +
    +        public Builder vpcUuid(String vpcUuid) {
    +            this._vpcUuid = vpcUuid;
    +            return this;
    +        }
    +
    +        public Builder domainTemplateName(String domainTemplateName) {
    +            this._domainTemplateName = domainTemplateName;
    +            return this;
    +        }
    +
    +        @Override
    +        public ShutDownVpcVspCommand build() {
    +            return new ShutDownVpcVspCommand(_domainUuid, _vpcUuid, _domainTemplateName);
    +        }
    +    }
    +
         @Override
         public boolean executeInSequence() {
             return false;
         }
     
    +    @Override
    +    public boolean equals(Object o) {
    --- End diff --
    
    Implemented <code>equals</code> method for the <code>Command</code> super class, calling it from subclass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---