Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-801-cloudstack@git.apache.org>
In-Reply-To: <git-pr-801-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP
 plugin...
Content-Type: text/plain
Message-Id: <20151026181306.BAF6DE042D@git1-us-west.apache.org>
Date: Mon, 26 Oct 2015 18:13:06 +0000 (UTC)

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43030803
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java ---
    @@ -79,4 +191,47 @@ public boolean executeInSequence() {
             return false;
         }
     
    +    @Override
    +    public boolean equals(Object o) {
    +        if (this == o) return true;
    +        if (o == null || getClass() != o.getClass()) return false;
    +
    +        ApplyAclRuleVspCommand that = (ApplyAclRuleVspCommand) o;
    +
    +        if (_egressDefaultPolicy != that._egressDefaultPolicy) return false;
    +        if (_isL2Network != that._isL2Network) return false;
    +        if (_networkAcl != that._networkAcl) return false;
    +        if (_networkId != that._networkId) return false;
    +        if (_networkReset != that._networkReset) return false;
    +        if (_aclRules != null ? !_aclRules.equals(that._aclRules) : that._aclRules != null) return false;
    +        if (_acsIngressAcl != null ? !_acsIngressAcl.equals(that._acsIngressAcl) : that._acsIngressAcl != null)
    +            return false;
    +        if (_domainTemplateName != null ? !_domainTemplateName.equals(that._domainTemplateName) : that._domainTemplateName != null)
    +            return false;
    +        if (_networkDomainUuid != null ? !_networkDomainUuid.equals(that._networkDomainUuid) : that._networkDomainUuid != null)
    +            return false;
    +        if (_networkName != null ? !_networkName.equals(that._networkName) : that._networkName != null) return false;
    +        if (_networkUuid != null ? !_networkUuid.equals(that._networkUuid) : that._networkUuid != null) return false;
    +        if (_vpcOrSubnetUuid != null ? !_vpcOrSubnetUuid.equals(that._vpcOrSubnetUuid) : that._vpcOrSubnetUuid != null)
    +            return false;
    +
    +        return true;
    +    }
    +
    +    @Override
    +    public int hashCode() {
    --- End diff --
    
    This ``equals`` implementation should include attributes from the ``Command`` super class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---