Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D685318413 for ; Sun, 18 Oct 2015 15:28:47 +0000 (UTC) Received: (qmail 80311 invoked by uid 500); 18 Oct 2015 15:28:47 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 80253 invoked by uid 500); 18 Oct 2015 15:28:47 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 80242 invoked by uid 99); 18 Oct 2015 15:28:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Oct 2015 15:28:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 237A3DFF09; Sun, 18 Oct 2015 15:28:47 +0000 (UTC) From: rafaelweingartner To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: Create test cases to getPatchFilePath met... Content-Type: text/plain Message-Id: <20151018152847.237A3DFF09@git1-us-west.apache.org> Date: Sun, 18 Oct 2015 15:28:47 +0000 (UTC) Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/944#issuecomment-149024959 @pedro-martins, it is nice that you wrote more tests to a class. However, there are some check style problems: C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:16: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:18: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:19: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:21: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:23: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:26: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:28: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:29: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\CitrixResourceBaseTest.java:32: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\XcpOssResourceTest.java:38: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\XcpOssResourceTest.java:44: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\XcpServerResourceTest.java:39: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\XcpServerResourceTest.java:45: Line has trailing spaces. C:\Users\Rafael\git\cloudstack\plugins\hypervisors\xenserver\test\com\cloud\hypervisor\xenserver\resource\XenServer650ResourceTest.java:38: Line has trailing spaces. Could you configure your eclipse java formatter? Here you can find a detailed explanation on how to do that: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---