Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0F6471857E for ; Mon, 12 Oct 2015 22:33:33 +0000 (UTC) Received: (qmail 16939 invoked by uid 500); 12 Oct 2015 22:33:32 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 16884 invoked by uid 500); 12 Oct 2015 22:33:32 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 16870 invoked by uid 99); 12 Oct 2015 22:33:32 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Oct 2015 22:33:32 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 51DA5E08EA; Mon, 12 Oct 2015 22:33:32 +0000 (UTC) From: jburwell To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin... Content-Type: text/plain Message-Id: <20151012223332.51DA5E08EA@git1-us-west.apache.org> Date: Mon, 12 Oct 2015 22:33:32 +0000 (UTC) Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-147540509 For classes implementing the ``equals`` and ``hashCode`` methods, please add a unit test case that utilizes Guava's EqualTester to verify their implementation. Please see this [article](http://blog.mafr.de/2014/07/21/testing-equals-with-guava/) for more information about its usage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---