Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-801-cloudstack@git.apache.org>
In-Reply-To: <git-pr-801-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP
 plugin...
Content-Type: text/plain
Message-Id: <20151012165459.14027DFF6F@git1-us-west.apache.org>
Date: Mon, 12 Oct 2015 16:54:59 +0000 (UTC)

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41776891
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java ---
    @@ -0,0 +1,60 @@
    +//
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +//
    +
    +package com.cloud.agent.api;
    +
    +import java.util.Collections;
    +import java.util.Map;
    +
    +public class UpdateNuageVspDeviceCommand extends Command {
    +
    +    private final Map<String, String> _parametersToBeUpdated;
    +
    +    public UpdateNuageVspDeviceCommand(Map<String, String> parametersToBeUpdated) {
    +        super();
    +        this._parametersToBeUpdated = parametersToBeUpdated;
    --- End diff --
    
    To prevent the impact of side-effects from changes to the ``parametersToBeUpdated`` in post construction behavior, copy the ``Map`` and wrap it in an unmodifiable as follows:
    ```
    this._parametersToBeUpdated = Collections.unmodifiableMap(new HashMap<String, String>(parametersToBeUpdated));
    ```
    This change will allow the return of the parameter in ``getParametersToBeUpdated`` without modification.
    
    An alternative, cleaner approach (which I prefer, but not commonly used in the CloudStack codebase) is to use Guava's ``ImmutableMap``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---