cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <...@git.apache.org>
Subject [GitHub] cloudstack pull request: cloud-apidoc module depends on cloud-clie...
Date Tue, 20 Oct 2015 11:31:57 GMT
GitHub user miguelaferreira opened a pull request:

    https://github.com/apache/cloudstack/pull/958

    cloud-apidoc module depends on cloud-client-ui

    When building the cloud-apidoc module a script called `./build-apidoc.sh` is executed
with an argument that points to `../../client/target/cloud-client-ui-${project.version}/WEB-INF/lib`.
The script uses that argument to build a Java classpath. However, since the cloud-apidoc module
does not explicitly depend on cloud-client-ui, a parallel maven build will often fail because
the required jars are not present when needed.
    
    Error message when build fails:
    ```
    Error: Could not find or load main class com.cloud.api.doc.ApiXmlDocWriter
    ```
    
    This PR makes the dependency explicit.
    
    Resulting build:
    ```
    mvn clean install -T4 -Pdeveloper,systemvm
    ....
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 09:02 min (Wall Clock)
    [INFO] Finished at: 2015-10-20T13:31:30+02:00
    [INFO] Final Memory: 98M/1526M
    [INFO] ------------------------------------------------------------------------
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/miguelaferreira/cloudstack cloud-apidoc-depends-on-cloud-client-ui

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/958.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #958
    
----
commit 9f9f6a2dda05e0e493c5a7192c3df2b77d55e61a
Author: Miguel Ferreira <miguelferreira@me.com>
Date:   2015-10-20T10:32:46Z

    cloud-apidoc module depends on cloud-client-ui

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message