cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: master build broken?
Date Thu, 22 Oct 2015 12:45:36 GMT
Thanks Wei,

As discussed on IM localhost works for me but only when not open ;) I
changed it to 127.0.0.128 and it works. I do not get the idea behind the
test and I don't think it is a unit test if a external host (or it's
absense) is required. I will fail after the point the exception is expected
with a clear message. Putting in a PR for the sake of it.

On Thu, Oct 22, 2015 at 2:14 PM, Wei ZHOU <ustcweizhou@gmail.com> wrote:

> Author:     Wei Zhou <w.zhou@tech.leaseweb.com>
> AuthorDate: Thu Aug 27 10:32:57 2015 +0200
> Commit:     Wei Zhou <w.zhou@tech.leaseweb.com>
> CommitDate: Thu Aug 27 10:32:57 2015 +0200
>
>     use fakelocalhost in BasicRestClientTest
> ---
>  .../com/cloud/utils/rest/BasicRestClientTest.java  |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git
> a/utils/src/test/java/com/cloud/utils/rest/BasicRestClientTest.java
> b/utils/src/test/java/com/cloud/utils/rest/BasicRestClientTest.java
> index c30103e..369af06 100644
> --- a/utils/src/test/java/com/cloud/utils/rest/BasicRestClientTest.java
> +++ b/utils/src/test/java/com/cloud/utils/rest/BasicRestClientTest.java
> @@ -41,7 +41,7 @@ import org.junit.Test;
>
>  public class BasicRestClientTest {
>
> -    private static final String LOCALHOST = "localhost";
> +    private static final String LOCALHOST = "fakelocalhost";
>      private static final String HTTPS = HttpConstants.HTTPS;
>
>      private static final StatusLine HTTP_200_REPSONSE = new
> BasicStatusLine(new ProtocolVersion(HTTPS, 1, 1), 200, "OK");
>
>
> 2015-10-22 12:41 GMT+02:00 Daan Hoogland <daan.hoogland@gmail.com>:
>
> > any clues out there? I backtracked master to 4 weeks ago and keep getting
> > this failure!?!
> >
> > On Thu, Oct 22, 2015 at 12:11 PM, Daan Hoogland <daan.hoogland@gmail.com
> >
> > wrote:
> >
> > > git reset --hard
> > > mvn -P developer,systemvm clean install
> > >
> > > leads to build failure in
> > > BasicRestClientTest.testExecuteRequestWhenClientThrowsIOException
> > Expected
> > > exception: com.cloud.utils.rest.CloudstackRESTException
> > >
> > > ‚Äčanybody else seeing this?‚Äč
> > >
> > > --
> > > Daan
> > >
> >
> >
> >
> > --
> > Daan
> >
>



-- 
Daan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message