cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9004: Add features to HyperVEn...
Date Sat, 31 Oct 2015 11:16:08 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1013#issuecomment-152724047
  
    @jharshman Very clear Josh. This would be for 4.7 then. based on review you have my LGTM.
We will need to run a test suite before merging but let's wait as it seems 4.6 can be out
next week. I've seen a convention coming up where people prefix their PRs with [4.7] in the
title. it makes sense for you to do the same
    
    Can you assign both (and any other related) tickets to yourself? Don't hesitate to call
in help if you need to.
    Do you have a good integration test environment yourself? It will also help accepting
if you can show how you tested your changes in unit-, system-, integration tests, though I'm
sure we'll manage to get this going.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message